Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-Pick] Fix QueryNode may panics when stopped (#21406) #21419

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

congqixia
Copy link
Contributor

See also #21460

/kind bug

Signed-off-by: Congqi Xia congqi.xia@zilliz.com

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Dec 28, 2022
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. approved labels Dec 28, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Dec 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2022

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2022

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #21419 (d751044) into 2.2.0 (d751044) will not change coverage.
The diff coverage is n/a.

❗ Current head d751044 differs from pull request most recent head 78e9d9f. Consider uploading reports for the commit 78e9d9f to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##            2.2.0   #21419   +/-   ##
=======================================
  Coverage   73.29%   73.29%           
=======================================
  Files         688      688           
  Lines       92992    92992           
=======================================
  Hits        68163    68163           
  Misses      21570    21570           
  Partials     3259     3259           

@mergify mergify bot added the ci-passed label Dec 29, 2022
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit ea89a5d into milvus-io:2.2.0 Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants