Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-Pick] Minor fix on segment metric #21977

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

soothing-rain
Copy link
Contributor

/kind improvement

Signed-off-by: Yuchen Gao yuchen.gao@zilliz.com

/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Feb 3, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 3, 2023
@soothing-rain soothing-rain changed the title Minor fix on segment metric [Cherry-Pick] Minor fix on segment metric Feb 3, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Feb 3, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, soothing-rain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

@soothing-rain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #21977 (ca9b307) into 2.2.0 (51f7519) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #21977      +/-   ##
==========================================
+ Coverage   81.72%   81.77%   +0.04%     
==========================================
  Files         700      700              
  Lines       98041    98041              
==========================================
+ Hits        80124    80171      +47     
+ Misses      14807    14772      -35     
+ Partials     3110     3098      -12     
Impacted Files Coverage Δ
internal/datacoord/meta.go 87.05% <100.00%> (+0.21%) ⬆️
internal/distributed/indexcoord/client/client.go 53.29% <0.00%> (-3.85%) ⬇️
internal/querynode/query_node.go 76.85% <0.00%> (-0.93%) ⬇️
internal/datacoord/segment_manager.go 87.25% <0.00%> (-0.84%) ⬇️
internal/distributed/datacoord/client/client.go 73.87% <0.00%> (-0.78%) ⬇️
internal/mq/msgstream/mq_msgstream.go 77.79% <0.00%> (-0.57%) ⬇️
internal/querynode/impl.go 66.55% <0.00%> (+0.16%) ⬆️
internal/proxy/util.go 91.52% <0.00%> (+0.43%) ⬆️
internal/querycoordv2/task/scheduler.go 78.93% <0.00%> (+0.59%) ⬆️
internal/datacoord/server.go 78.11% <0.00%> (+0.68%) ⬆️
... and 10 more

@soothing-rain
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 7, 2023
@sre-ci-robot sre-ci-robot merged commit 9d3a257 into milvus-io:2.2.0 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants