Protect DataCoord from calculating segment lines by stale log entries num #23069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-ci-robot
added
the
kind/improvement
yah01
force-pushed
the
fix-dc-segment-zero-line
branch
from
44acec8
to
b8fbb02
Compare
sre-ci-robot
added
size/S
|
@yah01 ut workflow job failed, comment |
Codecov Report
@@ Coverage Diff @@
## 2.2.5 #23069 +/- ##
==========================================
- Coverage 81.56% 81.54% -0.03%
==========================================
Files 709 709
Lines 100035 100050 +15
==========================================
- Hits 81595 81584 -11
- Misses 15273 15291 +18
- Partials 3167 3175 +8
|
yah01
force-pushed
the
fix-dc-segment-zero-line
branch
from
b8fbb02
to
03a11ce
Compare
|
@yah01 E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@yah01 ut workflow job failed, comment |
… num Signed-off-by: yah01 <yang.cen@zilliz.com>
yah01
force-pushed
the
fix-dc-segment-zero-line
branch
from
03a11ce
to
5a32fc6
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan, yah01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yah01
added a commit
to yah01/milvus
that referenced
this pull request
Mar 29, 2023
… num (milvus-io#23069) Signed-off-by: yah01 <yang.cen@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind improvement
related #22952
All Flush / Compact will re-calculate the number of rows by the method
ReCalcRowCount, then we can protect the meta by only respect this value when it's not 0