Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect DataCoord from calculating segment lines by stale log entries num #23092

Merged
merged 1 commit into from Mar 30, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Mar 29, 2023

/kind improvement
related #22952
All Flush / Compact will re-calculate the number of rows by the method ReCalcRowCount, then we can protect the meta by only respect this value when it's not 0

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 29, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 29, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Mar 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #23092 (c79f261) into 2.2.0 (e013093) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #23092      +/-   ##
==========================================
- Coverage   80.96%   80.94%   -0.03%     
==========================================
  Files         717      717              
  Lines      100522   100537      +15     
==========================================
- Hits        81391    81380      -11     
- Misses      15962    15985      +23     
- Partials     3169     3172       +3     
Impacted Files Coverage Δ
internal/datacoord/meta.go 85.99% <66.66%> (-0.71%) ⬇️
internal/datacoord/services.go 83.35% <100.00%> (ø)
internal/util/segmentutil/utils.go 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 29, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 05d2a29 into milvus-io:2.2.0 Mar 30, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants