Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix node up #23626

Merged
merged 1 commit into from
Apr 27, 2023
Merged

fix node up #23626

merged 1 commit into from
Apr 27, 2023

Conversation

weiliu1031
Copy link
Contributor

Signed-off-by: Wei Liu wei.liu@zilliz.com
issue: #22782

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 23, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Apr 23, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 23, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 23, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@weiliu1031
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031
fix node up
8ff1d95 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@codecov
Copy link

codecov bot commented Apr 26, 2023 •
edited
Loading

Codecov Report

Merging #23626 (8ff1d95) into 2.2.0 (b7cda1b) will increase coverage by 0.01%.
The diff coverage is 94.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #23626      +/-   ##
==========================================
+ Coverage   80.62%   80.63%   +0.01%     
==========================================
  Files         713      713              
  Lines      101497   101555      +58     
==========================================
+ Hits        81834    81891      +57     
+ Misses      16464    16463       -1     
- Partials     3199     3201       +2
Impacted Files Coverage Δ
internal/util/paramtable/component_param.go 87.75% <75.00%> (-0.21%) ⬇️
internal/querycoordv2/server.go 77.33% <100.00%> (+1.66%) ⬆️
internal/querycoordv2/services.go 84.07% <100.00%> (+0.06%) ⬆️

... and 21 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 26, 2023
congqixia
congqixia approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2ee23fe into milvus-io:2.2.0 Apr 27, 2023
@weiliu1031 weiliu1031 mentioned this pull request Apr 28, 2023
Closed
1 task
@weiliu1031 weiliu1031 mentioned this pull request May 19, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliu1031 @sre-ci-robot @congqixia