Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support search with default params #24516

Merged
merged 1 commit into from
May 30, 2023
Merged

Support search with default params #24516

merged 1 commit into from
May 30, 2023

Conversation

xiaocai2333
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 30, 2023
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/compilation labels May 30, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 30, 2023
@mergify
Copy link
Contributor

mergify bot commented May 30, 2023

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 30, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 30, 2023

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@xiaocai2333
Support search with default params
4be2cc1 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented May 30, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Contributor

czs007 commented May 30, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #24516 (4be2cc1) into 2.2.0 (8729f82) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24516      +/-   ##
==========================================
- Coverage   80.88%   80.86%   -0.02%     
==========================================
  Files         759      759              
  Lines      106238   106368     +130     
==========================================
+ Hits        85930    86016      +86     
- Misses      17002    17036      +34     
- Partials     3306     3316      +10
Impacted Files Coverage Δ
internal/core/src/index/VectorDiskIndex.cpp 0.00% <0.00%> (ø)
internal/core/src/index/VectorMemIndex.cpp 63.70% <ø> (-0.30%) ⬇️
internal/proxy/task_search.go 74.54% <0.00%> (-0.91%) ⬇️

... and 41 files with indirect coverage changes

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 30, 2023
@sre-ci-robot sre-ci-robot merged commit f5a9a90 into milvus-io:2.2.0 May 30, 2023
@xiaocai2333 xiaocai2333 deleted the remove_search_params_check branch June 7, 2023 03:31
xiaocai2333 added a commit to xiaocai2333/milvus that referenced this pull request Jun 30, 2023
@xiaocai2333
Support search with default params(milvus-io#24516)
62ca924 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jul 3, 2023
@xiaocai2333
Support search with default params(#24516) (#25255)
4fdbc5a 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
zhuwenxing pushed a commit to mmga-lab/milvus that referenced this pull request Jul 25, 2023
@xiaocai2333 @zhuwenxing
Support search with default params(milvus-io#24516) (milvus-io#25255)
a6803c1 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaocai2333 @czs007 @sre-ci-robot