Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed db parameter #25759

Merged
merged 1 commit into from Jul 20, 2023

Conversation

jaime0815
Copy link
Contributor

/kind improvement

Signed-off-by: jaime <yun.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines. labels Jul 19, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jul 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented Jul 19, 2023

rerun ut

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #25759 (a7a77b5) into 2.2.0 (04c3240) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #25759      +/-   ##
==========================================
+ Coverage   80.80%   80.86%   +0.05%     
==========================================
  Files         766      766              
  Lines      109873   109873              
==========================================
+ Hits        88788    88846      +58     
+ Misses      17694    17648      -46     
+ Partials     3391     3379      -12     
Impacted Files Coverage Δ
internal/rootcoord/import_manager.go 78.01% <100.00%> (ø)

... and 19 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 19, 2023
@czs007
Copy link
Contributor

czs007 commented Jul 20, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c9e1d0b into milvus-io:2.2.0 Jul 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants