Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missed db parameter #25759

Merged
merged 1 commit into from Jul 20, 2023
Merged

Fix missed db parameter #25759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions internal/rootcoord/import_manager.go
View file
Open in desktop
Expand Up @@ -29,14 +29,15 @@ import (
"github.com/golang/protobuf/proto"
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
"github.com/samber/lo"
"go.uber.org/zap"

"github.com/milvus-io/milvus/internal/kv"
"github.com/milvus-io/milvus/internal/log"
"github.com/milvus-io/milvus/internal/proto/datapb"
"github.com/milvus-io/milvus/internal/proto/rootcoordpb"
"github.com/milvus-io/milvus/internal/util/importutil"
"github.com/milvus-io/milvus/internal/util/typeutil"
"github.com/samber/lo"
"go.uber.org/zap"
)

const (
Expand Down Expand Up @@ -469,7 +470,7 @@ func (m *importManager) importJob(ctx context.Context, req *milvuspb.ImportReque
// since here we always return task list to client no matter something missed.
// We make the method setCollectionPartitionName() returns error
// because we need to make sure coverage all the code branch in unittest case.
_ = m.setCollectionPartitionName("", cID, pID, newTask)
_ = m.setCollectionPartitionName(req.GetDbName(), cID, pID, newTask)
resp.Tasks = append(resp.Tasks, newTask.GetId())
taskList[i] = newTask.GetId()
log.Info("new task created as pending task",
Expand All @@ -484,7 +485,7 @@ func (m *importManager) importJob(ctx context.Context, req *milvuspb.ImportReque
}
log.Info("row-based import request processed", zap.Any("task IDs", taskList))
} else {
// TODO: Merge duplicated code :(
// qTODO: Merge duplicated code :(
// for column-based, all files is a task
tID, _, err := m.idAllocator(1)
if err != nil {
Expand Down