Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix get binary vector from chunk cache (#28866) #28884

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

bigsheeper
Copy link
Contributor

The way of getting binary vector size is wrong. This PR will fix it.

issue: #28865

pr: #28866

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 1, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #28884 (bcc9a0c) into 2.3 (ce8219f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #28884      +/-   ##
==========================================
- Coverage   82.00%   81.99%   -0.01%     
==========================================
  Files         820      820              
  Lines      118623   118622       -1     
==========================================
- Hits        97274    97266       -8     
- Misses      18132    18138       +6     
- Partials     3217     3218       +1     
Files Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.cpp 78.74% <0.00%> (+0.12%) ⬆️

... and 13 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Dec 1, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c936cc8 into milvus-io:2.3 Dec 1, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants