Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] azure ListObjects (#27931) #28894

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Dec 1, 2023

issue: #27932
master pr: #27931

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 1, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 1, 2023
Copy link
Contributor

mergify bot commented Dec 1, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 1, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: PowderLi <min.li@zilliz.com>
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #28894 (782a422) into 2.3 (ce8219f) will decrease coverage by 0.02%.
Report is 3 commits behind head on 2.3.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #28894      +/-   ##
==========================================
- Coverage   82.00%   81.99%   -0.02%     
==========================================
  Files         820      829       +9     
  Lines      118623   118678      +55     
==========================================
+ Hits        97274    97306      +32     
- Misses      18132    18158      +26     
+ Partials     3217     3214       -3     
Files Coverage Δ
internal/storage/minio_object_storage.go 79.45% <100.00%> (+3.26%) ⬆️
internal/storage/azure_object_storage.go 91.17% <91.17%> (-1.51%) ⬇️
internal/storage/remote_chunk_manager.go 74.20% <47.82%> (-5.12%) ⬇️

... and 162 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 1, 2023
@czs007
Copy link
Contributor

czs007 commented Dec 1, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 96c8e8d into milvus-io:2.3 Dec 1, 2023
14 checks passed
@PowderLi PowderLi changed the title fix: azure ListObjects (#27931) fix: [cherry-pick] azure ListObjects (#27931) Dec 1, 2023
sre-ci-robot pushed a commit that referenced this pull request Dec 3, 2023
issue: #27932
master pr: #27931
2.3 pr: #28894

Signed-off-by: PowderLi <min.li@zilliz.com>
@PowderLi PowderLi deleted the 2.3-fix-azure-ListObjects branch January 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants