Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix azure ListObjects #27931

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix azure ListObjects #27931

merged 1 commit into from
Nov 1, 2023

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Oct 25, 2023 •
edited
Loading

/kind bug
to #27932

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@PowderLi Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi PowderLi force-pushed the master-fix-azure-ListObjects branch 3 times, most recently from a66eb37 to 93c1517 Compare October 26, 2023 08:49
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #27931 (01b9d85) into master (4fbe3c9) will increase coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 95.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27931      +/-   ##
==========================================
+ Coverage   81.82%   81.83%   +0.01%     
==========================================
  Files         822      831       +9     
  Lines      117567   117658      +91     
==========================================
+ Hits        96201    96291      +90     
- Misses      18167    18170       +3     
+ Partials     3199     3197       -2
Files Coverage Δ
internal/storage/minio_object_storage.go 79.45% <100.00%> (+3.26%) ⬆️
internal/storage/remote_chunk_manager.go 80.14% <100.00%> (-1.89%) ⬇️
internal/storage/azure_object_storage.go 91.17% <91.17%> (-1.51%) ⬇️

... and 160 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 26, 2023
@mergify mergify bot added ci-passed and removed ci-passed labels Oct 27, 2023
@mergify mergify bot removed the ci-passed label Oct 31, 2023
@PowderLi PowderLi force-pushed the master-fix-azure-ListObjects branch 2 times, most recently from 771b2ca to 8b654d9 Compare October 31, 2023 09:41
@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

@PowderLi
fix azure ListObjects
01b9d85 
Signed-off-by: PowderLi <min.li@zilliz.com>
@mergify mergify bot added the ci-passed label Nov 1, 2023
@czs007
Copy link
Collaborator

czs007 commented Nov 1, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0252871 into milvus-io:master Nov 1, 2023
14 checks passed
@PowderLi PowderLi deleted the master-fix-azure-ListObjects branch November 14, 2023 04:19
@PowderLi PowderLi mentioned this pull request Dec 1, 2023
Merged
PowderLi added a commit to PowderLi/milvus that referenced this pull request Dec 1, 2023
@PowderLi
fix azure ListObjects (milvus-io#27931)
782a422 
Signed-off-by: PowderLi <min.li@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Dec 1, 2023
@PowderLi
fix: azure ListObjects (#27931) (#28894)
96c8e8d 
issue: #27932
master pr: #27931

Signed-off-by: PowderLi <min.li@zilliz.com>
@PowderLi PowderLi mentioned this pull request Dec 1, 2023
Merged
PowderLi added a commit to PowderLi/milvus that referenced this pull request Dec 1, 2023
@PowderLi
fix azure ListObjects (milvus-io#27931)
e47c39b 
Signed-off-by: PowderLi <min.li@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Dec 3, 2023
@PowderLi
fix: [cherry-pick] azure ListObjects (#27931) (#28913)
628df97 
issue: #27932
master pr: #27931
2.3 pr: #28894

Signed-off-by: PowderLi <min.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunby sunby Awaiting requested review from sunby

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PowderLi @czs007 @sre-ci-robot