Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: creating growing segments may introduce many threads #29314

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Dec 19, 2023

many growing segments may be created in a short time and there is no restriction to the process, the CGO call will leave many threads

related: #29282
pr: #29306

many growing segments may be created in a short time and there is no restriction to the process, the CGO call will leave many threads

Signed-off-by: yah01 <yah2er0ne@outlook.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 19, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 19, 2023
Copy link
Contributor

mergify bot commented Dec 19, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Dec 19, 2023

/run-cpu-e2e

1 similar comment
@yah01
Copy link
Member Author

yah01 commented Dec 19, 2023

/run-cpu-e2e

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #29314 (458a007) into 2.3 (97d71c2) will increase coverage by 0.01%.
Report is 12 commits behind head on 2.3.
The diff coverage is 76.19%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29314      +/-   ##
==========================================
+ Coverage   82.09%   82.10%   +0.01%     
==========================================
  Files         832      832              
  Lines      119301   119366      +65     
==========================================
+ Hits        97936    98004      +68     
+ Misses      18143    18134       -9     
- Partials     3222     3228       +6     
Files Coverage Δ
internal/core/src/common/RangeSearchHelper.cpp 100.00% <ø> (ø)
internal/datanode/flow_graph_time_tick_node.go 90.66% <100.00%> (+1.60%) ⬆️
internal/datanode/flow_graph_dd_node.go 92.38% <0.00%> (ø)
internal/querynodev2/segments/segment.go 75.48% <63.63%> (-0.27%) ⬇️

... and 24 files with indirect coverage changes

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Dec 19, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit cd9e3c4 into milvus-io:2.3 Dec 19, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants