Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: optimize the loading index performance (#29894) #30018

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Jan 16, 2024

this utilizes concurrent loading
pr: #29894

this utilizes concurrent loading

Signed-off-by: yah01 <yang.cen@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 16, 2024
Copy link
Contributor

mergify bot commented Jan 16, 2024

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (81fdb6f) 82.20% compared to head (60efe08) 82.21%.
Report is 21 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #30018   +/-   ##
=======================================
  Coverage   82.20%   82.21%           
=======================================
  Files         834      825    -9     
  Lines      120405   120349   -56     
=======================================
- Hits        98984    98940   -44     
+ Misses      18193    18182   -11     
+ Partials     3228     3227    -1     
Files Coverage Δ
internal/core/src/index/VectorMemIndex.cpp 65.81% <0.00%> (+2.18%) ⬆️

... and 160 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jan 22, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a8d9b0c into milvus-io:2.3 Jan 22, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants