Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support related privilege for grant api #30153

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jan 20, 2024

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jan 20, 2024
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/dependency Pull requests that update a dependency file labels Jan 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 20, 2024
Copy link
Contributor

mergify bot commented Jan 20, 2024

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG SimFG force-pushed the master branch 2 times, most recently from 486e825 to 964cd21 Compare January 22, 2024 05:14
sre-ci-robot pushed a commit that referenced this pull request Jan 22, 2024
/kind improvement
pr: #30153

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
@SimFG
Copy link
Contributor Author

SimFG commented Jan 22, 2024

rerun ut

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86f4886) 83.14% compared to head (56df03b) 83.18%.
Report is 32 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30153      +/-   ##
==========================================
+ Coverage   83.14%   83.18%   +0.03%     
==========================================
  Files         700      700              
  Lines      112841   113044     +203     
==========================================
+ Hits        93817    94030     +213     
+ Misses      15418    15397      -21     
- Partials     3606     3617      +11     
Files Coverage Δ
internal/proxy/impl.go 85.81% <100.00%> (+0.04%) ⬆️
pkg/util/constant.go 91.42% <ø> (+8.57%) ⬆️

... and 43 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 23, 2024
@czs007
Copy link
Contributor

czs007 commented Jan 23, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4637659 into milvus-io:master Jan 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants