Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.3] support related privilege for grant api #30154

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jan 20, 2024

/kind improvement
pr: #30153

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jan 20, 2024
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jan 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 20, 2024
Copy link
Contributor

mergify bot commented Jan 20, 2024

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: SimFG <bang.fu@zilliz.com>
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (be1470a) 82.23% compared to head (8e57754) 82.23%.
Report is 9 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              2.3   #30154    +/-   ##
========================================
  Coverage   82.23%   82.23%            
========================================
  Files         836      836            
  Lines      120613   120795   +182     
========================================
+ Hits        99186    99341   +155     
- Misses      18198    18210    +12     
- Partials     3229     3244    +15     
Files Coverage Δ
internal/datacoord/util.go 99.09% <100.00%> (+0.01%) ⬆️
internal/proxy/impl.go 85.72% <100.00%> (+0.04%) ⬆️
pkg/util/constant.go 91.42% <ø> (+8.57%) ⬆️
pkg/util/indexparams/index_params.go 86.54% <81.25%> (-0.89%) ⬇️
internal/datacoord/index_builder.go 89.96% <0.00%> (-2.02%) ⬇️

... and 19 files with indirect coverage changes

@yanliang567 yanliang567 added this to the 2.3.6 milestone Jan 22, 2024
@czs007
Copy link
Contributor

czs007 commented Jan 22, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 22, 2024
@sre-ci-robot sre-ci-robot merged commit 2465d86 into milvus-io:2.3 Jan 22, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm manual-pass manually set pass before ci-passed labeled size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants