Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add a weight for growing row count when balancing segments #30293

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jan 25, 2024

Cherry-pick from master
pr: #30271

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 25, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jan 25, 2024
Copy link
Contributor

mergify bot commented Jan 25, 2024

@sunby Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Jan 25, 2024
Copy link
Contributor

mergify bot commented Jan 25, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d182a51) 82.09% compared to head (ae5e40a) 82.10%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #30293   +/-   ##
=======================================
  Coverage   82.09%   82.10%           
=======================================
  Files         840      840           
  Lines      121034   121044   +10     
=======================================
+ Hits        99368    99388   +20     
+ Misses      18422    18415    -7     
+ Partials     3244     3241    -3     
Files Coverage Δ
...ernal/querycoordv2/balance/score_based_balancer.go 95.71% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.33% <100.00%> (+<0.01%) ⬆️

... and 15 files with indirect coverage changes

@congqixia
Copy link
Contributor

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 25, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2c4d060 into milvus-io:2.3 Jan 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants