-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add graceful stop timeout to avoid node stop hang under extreme cases #30320
enhance: add graceful stop timeout to avoid node stop hang under extreme cases #30320
Conversation
…eme cases Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh E2e jenkins job failed, comment |
@chyezh ut workflow job failed, comment |
5cdc0b4
to
ad01a62
Compare
@chyezh E2e jenkins job failed, comment |
/run-cpu-e2e |
@chyezh E2e jenkins job failed, comment |
/run-cpu-e2e |
/approve |
@chyezh ut workflow job failed, comment |
ad01a62
to
fdb90ff
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chyezh, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #30320 +/- ##
==========================================
+ Coverage 82.06% 82.10% +0.03%
==========================================
Files 840 840
Lines 121139 121170 +31
==========================================
+ Hits 99413 99483 +70
+ Misses 18487 18446 -41
- Partials 3239 3241 +2
|
@chyezh ut workflow job failed, comment |
fdb90ff
to
13e9239
Compare
/lgtm |
@chyezh ut workflow job failed, comment |
13e9239
to
0060e4a
Compare
@chyezh E2e jenkins job failed, comment |
/run-cpu-e2e |
3 similar comments
/run-cpu-e2e |
/run-cpu-e2e |
/run-cpu-e2e |
Signed-off-by: chyezh <chyezh@outlook.com>
0060e4a
to
b6cf703
Compare
rerun ut |
/lgtm |
@chyezh E2e jenkins job failed, comment |
/run-cpu-e2e |
e2e passed, but pipeline hang at log uploading. manual pass |
LivenessCheck
do not perform graceful shutdown now.issue: #30310
pr: #30317
also see: #30306