Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support varchar autoid when bulkinsert(#30377) #30448

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Feb 1, 2024

related pr: #30377

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Feb 1, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Feb 1, 2024
Copy link
Contributor

mergify bot commented Feb 1, 2024

@smellthemoon Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Feb 1, 2024
@smellthemoon smellthemoon changed the title enhance: support varchar autoid when bulkinsert enhance: support varchar autoid when bulkinsert(#20337) Feb 1, 2024
@smellthemoon smellthemoon changed the title enhance: support varchar autoid when bulkinsert(#20337) enhance: support varchar autoid when bulkinsert(#30337) Feb 1, 2024
@smellthemoon smellthemoon changed the title enhance: support varchar autoid when bulkinsert(#30337) enhance: support varchar autoid when bulkinsert(#30377) Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (910e68f) 82.13% compared to head (4f82ec9) 82.13%.
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #30448   +/-   ##
=======================================
  Coverage   82.13%   82.13%           
=======================================
  Files         841      841           
  Lines      121223   121233   +10     
=======================================
+ Hits        99562    99573   +11     
+ Misses      18424    18420    -4     
- Partials     3237     3240    +3     
Files Coverage Δ
internal/util/importutil/import_util.go 91.60% <100.00%> (+0.55%) ⬆️

... and 15 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Feb 2, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 692dceb into milvus-io:2.3 Feb 2, 2024
14 checks passed
@mergify mergify bot removed the ci-passed label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants