Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add configurable memory index load predict memory usage factor #30561

Merged
merged 1 commit into from
Mar 1, 2024
Merged

enhance: add configurable memory index load predict memory usage factor #30561

merged 1 commit into from
Mar 1, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Feb 6, 2024 •
edited

related pr: #30475

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 6, 2024
@chyezh chyezh mentioned this pull request Feb 6, 2024
Merged
@chyezh
Copy link
Contributor Author

chyezh commented Feb 6, 2024

\hold, wait for related pr: #30473

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (a5a4ca8) to head (6a72751).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30561      +/-   ##
==========================================
- Coverage   80.75%   80.46%   -0.29%     
==========================================
  Files         964      964              
  Lines      137205   137267      +62     
==========================================
- Hits       110799   110458     -341     
- Misses      22696    23084     +388     
- Partials     3710     3725      +15
Files Coverage Δ
internal/querynodev2/segments/index_attr_cache.go 100.00% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.30% <100.00%> (-0.06%) ⬇️
tests/integration/minicluster_v2.go 62.11% <100.00%> (ø)

... and 34 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 6, 2024
sre-ci-robot pushed a commit that referenced this pull request Feb 6, 2024
@chyezh
enhance: add configurable memory index load predict memory usage fact…
be1bd96 
…or (#30563)

pr: #30561

related pr: #30475

Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the feat_configurable_memory_predict_master branch from 2b0bbeb to 9ef83f1 Compare February 21, 2024 06:25
@sre-ci-robot sre-ci-robot removed the lgtm label Feb 21, 2024
@mergify mergify bot removed the ci-passed label Feb 21, 2024
@chyezh chyezh force-pushed the feat_configurable_memory_predict_master branch from 9ef83f1 to 3edbc8b Compare February 21, 2024 06:27
@chyezh
Copy link
Contributor Author

chyezh commented Feb 21, 2024

rerun ut

3 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Feb 21, 2024

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Feb 22, 2024

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Feb 22, 2024

rerun ut

@chyezh chyezh force-pushed the feat_configurable_memory_predict_master branch from 3edbc8b to 2b4eff6 Compare February 22, 2024 03:07
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 22, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Feb 22, 2024

rerun ut

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Feb 22, 2024

rerun ut

@chyezh chyezh force-pushed the feat_configurable_memory_predict_master branch from 2b4eff6 to a898ea2 Compare February 23, 2024 03:18
chyezh
chyezh commented Feb 23, 2024
View reviewed changes
tests/integration/minicluster_v2.go
@@ -76,7 +76,7 @@ func DefaultParams() map[string]string {
params.LocalStorageCfg.Path.Key: path.Join("/tmp", testPath),
params.CommonCfg.StorageType.Key: "local",
params.DataNodeCfg.MemoryForceSyncEnable.Key: "false", // local execution will print too many logs
params.CommonCfg.GracefulStopTimeout.Key: "10",
params.CommonCfg.GracefulStopTimeout.Key: "30",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too short query node graceful timeout.
Causing querynode_test's stop testing failure.
(search will return service not ready).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only in integration test

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 23, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 27, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the feat_configurable_memory_predict_master branch 2 times, most recently from 554163a to 232d423 Compare February 28, 2024 02:06
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Feb 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Feb 28, 2024

/run-cpu-e2e

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Feb 28, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 28, 2024
@chyezh chyezh force-pushed the feat_configurable_memory_predict_master branch from 232d423 to ab277b1 Compare February 29, 2024 12:14
@mergify mergify bot removed the ci-passed label Feb 29, 2024
@czs007
Copy link
Contributor

czs007 commented Feb 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Feb 29, 2024

/run-cpu-e2e

3 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Feb 29, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Feb 29, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Mar 1, 2024

/run-cpu-e2e

@chyezh chyezh force-pushed the feat_configurable_memory_predict_master branch from ab277b1 to 6a72751 Compare March 1, 2024 03:14
@sre-ci-robot sre-ci-robot removed the lgtm label Mar 1, 2024
@mergify mergify bot added the ci-passed label Mar 1, 2024
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit dd957cf into milvus-io:master Mar 1, 2024
13 of 14 checks passed
@chyezh chyezh deleted the feat_configurable_memory_predict_master branch March 1, 2024 07:25
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this pull request Mar 3, 2024
@chyezh @MrPresent-Han
enhance: add configurable memory index load predict memory usage fact…
62c5e69 
…or (milvus-io#30561)

related pr: milvus-io#30475

Signed-off-by: chyezh <chyezh@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jaime0815 jaime0815

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chyezh @jaime0815 @czs007 @sre-ci-robot