-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: calculate the accuracy memory usage while loading segment (#30473) #30475
Conversation
@yah01 E2e jenkins job failed, comment |
@yah01 E2e jenkins job failed, comment |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #30475 +/- ##
==========================================
+ Coverage 82.11% 82.16% +0.04%
==========================================
Files 841 831 -10
Lines 121261 121192 -69
==========================================
- Hits 99579 99572 -7
+ Misses 18436 18385 -51
+ Partials 3246 3235 -11
|
the old version Knowhere would copy the index data while loading, we need to consider this to avoid OOM. Knowhere provides a util function to indicate whether it will load the index with disk, if not, we need to double the memory usage prediction for index data Signed-off-by: yah01 <yang.cen@zilliz.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, yah01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…or (milvus-io#30561) related pr: milvus-io#30475 Signed-off-by: chyezh <chyezh@outlook.com>
the old version Knowhere would copy the index data while loading, we need to consider this to avoid OOM.
Knowhere provides a util function to indicate whether it will load the index with disk, if not, we need to double the memory usage prediction for index data
pr: #30473