Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong num_entities used when mmap variable length data #30848

Merged
merged 3 commits into from
Feb 28, 2024
Merged

fix: wrong num_entities used when mmap variable length data #30848

merged 3 commits into from
Feb 28, 2024

Conversation

longjiquan
Copy link
Contributor

@longjiquan
fix: wrong num_entities used when mmap variable length data
76edf93 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 27, 2024
@longjiquan longjiquan mentioned this pull request Feb 27, 2024
Closed
1 task
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 27, 2024
@czs007
Copy link
Contributor

czs007 commented Feb 27, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 27, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (57397b1) to head (e985b67).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30848      +/-   ##
==========================================
- Coverage   80.69%   80.66%   -0.03%     
==========================================
  Files         952      952              
  Lines      137065   137072       +7     
==========================================
- Hits       110598   110572      -26     
- Misses      22745    22769      +24     
- Partials     3722     3731       +9
Files Coverage Δ
internal/core/src/mmap/Column.h 96.31% <100.00%> (ø)

... and 17 files with indirect coverage changes

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 27, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot removed the lgtm label Feb 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 27, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Feb 28, 2024
@czs007
Copy link
Contributor

czs007 commented Feb 28, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 4459078 into milvus-io:master Feb 28, 2024
13 checks passed
@longjiquan longjiquan deleted the fix-str-mmap branch February 28, 2024 08:43
@sunby sunby mentioned this pull request Mar 14, 2024
Open
1 task
longjiquan added a commit to longjiquan/milvus that referenced this pull request Mar 14, 2024
@longjiquan
fix: wrong num_entities used when mmap variable length data (milvus-i…
3e0e915 
…o#30848)

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@longjiquan longjiquan mentioned this pull request Mar 14, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Mar 14, 2024
@longjiquan
fix: wrong num_entities used when mmap variable length data (#30848) (#…
50bfde9 
…31274)

#30728
pr: #30848

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sunby sunby mentioned this pull request Mar 19, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@longjiquan @czs007 @sre-ci-robot