Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong num_entities used when mmap variable length data (#30848) #31274

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

longjiquan
Copy link
Contributor

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 14, 2024
Copy link
Contributor

mergify bot commented Mar 14, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (7105e0b) to head (3e0e915).
Report is 5 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31274      +/-   ##
==========================================
+ Coverage   82.24%   82.25%   +0.01%     
==========================================
  Files         844      834      -10     
  Lines      122234   122151      -83     
==========================================
- Hits       100526   100480      -46     
+ Misses      18480    18437      -43     
- Partials     3228     3234       +6     
Files Coverage Δ
internal/core/src/mmap/Column.h 95.26% <100.00%> (-2.24%) ⬇️

... and 167 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 14, 2024
@czs007
Copy link
Contributor

czs007 commented Mar 14, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 50bfde9 into milvus-io:2.3 Mar 14, 2024
14 checks passed
@longjiquan longjiquan deleted the cp-30804 branch March 15, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants