Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Cherry-pick] Remove time tick delay metrics when nodes go offline (#30833) #30879

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #30833
See also #30832

This PR removes time tick delay metrics when rootcoord GetMetrics response does not have previously existed querynode/datanode

Also add unit tests for this case


…30833)

See also milvus-io#30832

This PR removes time tick delay metrics when rootcoord GetMetrics
response does not have previously existed querynode/datanode

Also add unit tests for this case

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi.Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Feb 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 28, 2024
Copy link
Contributor

mergify bot commented Feb 28, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 28, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Feb 28, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 28, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (e17775a) to head (2113999).
Report is 11 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30879      +/-   ##
==========================================
+ Coverage   82.14%   82.18%   +0.04%     
==========================================
  Files         841      841              
  Lines      121399   121411      +12     
==========================================
+ Hits        99727    99787      +60     
+ Misses      18436    18394      -42     
+ Partials     3236     3230       -6     
Files Coverage Δ
internal/rootcoord/quota_center.go 90.77% <100.00%> (+2.05%) ⬆️
pkg/util/testutils/prometheus_metric.go 100.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 28, 2024
@yanliang567 yanliang567 added this to the 2.3.11 milestone Feb 28, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit df16bf6 into milvus-io:2.3 Feb 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants