-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Cherry-pick] Remove time tick delay metrics when nodes go offline (#30833) #30879
Conversation
…30833) See also milvus-io#30832 This PR removes time tick delay metrics when rootcoord GetMetrics response does not have previously existed querynode/datanode Also add unit tests for this case --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com> Signed-off-by: Congqi.Xia <congqi.xia@zilliz.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
@congqixia ut workflow job failed, comment |
1 similar comment
@congqixia ut workflow job failed, comment |
@congqixia E2e jenkins job failed, comment |
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #30879 +/- ##
==========================================
+ Coverage 82.14% 82.18% +0.04%
==========================================
Files 841 841
Lines 121399 121411 +12
==========================================
+ Hits 99727 99787 +60
+ Misses 18436 18394 -42
+ Partials 3236 3230 -6
|
/lgtm |
Cherry-pick from master
pr: #30833
See also #30832
This PR removes time tick delay metrics when rootcoord GetMetrics response does not have previously existed querynode/datanode
Also add unit tests for this case