Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: permissions on /milvus for OpenShift compatibility #30937

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix: permissions on /milvus for OpenShift compatibility #30937

merged 1 commit into from
Mar 4, 2024

Conversation

haorenfsa
Copy link
Contributor

@haorenfsa haorenfsa commented Feb 29, 2024 •
edited
Loading

Fixes #25565
Cherry-pick
pr: #30775

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 29, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Feb 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@haorenfsa Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@haorenfsa Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@haorenfsa

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (b0569f4) to head (2d1619c).
Report is 4 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #30937   +/-   ##
=======================================
  Coverage   82.19%   82.19%           
=======================================
  Files         843      843           
  Lines      121687   121687           
=======================================
+ Hits       100017   100022    +5     
+ Misses      18443    18436    -7     
- Partials     3227     3229    +2

see 15 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@haorenfsa E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

@haorenfsa E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 added this to the 2.3.11 milestone Mar 4, 2024
@guimou @haorenfsa
fix: fix permissions on /milvus for OpenShift compatibility (milvus-i…
2d1619c 
…o#30775)

OpenShift runs Pods with a random uid and gid 0.
As Milvus needs to write into the /milvus directory, this fix modifies
the group permissions to allow the root group (gid 0) to write into it.
This is a simple solution that allows to run Milvus on OpenShift without
adding security constraints, use special ServiceAccounts or whatever.
This should also not impact any other kubernetes platform as it's a
simple group permission change, nothing regarding the userid.

Note: Other actions are necessary to properly deploy the full stack
(Minio, Pulsar,...) on OpenShift. I will document them in the helm chart
project.

Fixes milvus-io#25565

Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com>
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
@mergify mergify bot added dco-passed DCO check passed. ci-passed and removed needs-dco DCO is missing in this pull request. do-not-merge/missing-related-pr ci-passed labels Mar 4, 2024
@haorenfsa haorenfsa changed the title Fix permissions on /milvus for OpenShift compatibility fix: permissions on /milvus for OpenShift compatibility Mar 4, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug ci-passed and removed do-not-merge/invalid-pr-format labels Mar 4, 2024
@czs007
Copy link
Contributor

czs007 commented Mar 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7014d35 into milvus-io:2.3 Mar 4, 2024
14 checks passed
@haorenfsa haorenfsa deleted the 2.3 branch March 4, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@LoveEachDay LoveEachDay Awaiting requested review from LoveEachDay

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
2.3.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haorenfsa @czs007 @sre-ci-robot @guimou