-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix permissions on /milvus for OpenShift compatibility #30775
fix: fix permissions on /milvus for OpenShift compatibility #30775
Conversation
Welcome @guimou! It looks like this is your first PR to milvus-io/milvus 🎉 |
@guimou Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com>
abfe4ac
to
da40d81
Compare
@LoveEachDay take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@guimou Thanks for fixing this issue. @LoveEachDay Can you let me know when the next release is scheduled and if this fix will be included? Thank you. |
Hi @arunkumara8, we usually release minor version every 2 or 3 weeks. this fix will be included if its cherry-pick to v2.3 branch is merged. |
rerun ut |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30775 +/- ##
==========================================
+ Coverage 80.48% 80.72% +0.23%
==========================================
Files 964 964
Lines 137160 137161 +1
==========================================
+ Hits 110400 110719 +319
+ Misses 23036 22727 -309
+ Partials 3724 3715 -9 |
/assign @czs007 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, guimou, LoveEachDay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…o#30775) OpenShift runs Pods with a random uid and gid 0. As Milvus needs to write into the /milvus directory, this fix modifies the group permissions to allow the root group (gid 0) to write into it. This is a simple solution that allows to run Milvus on OpenShift without adding security constraints, use special ServiceAccounts or whatever. This should also not impact any other kubernetes platform as it's a simple group permission change, nothing regarding the userid. Note: Other actions are necessary to properly deploy the full stack (Minio, Pulsar,...) on OpenShift. I will document them in the helm chart project. Fixes milvus-io#25565 Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com>
…o#30775) OpenShift runs Pods with a random uid and gid 0. As Milvus needs to write into the /milvus directory, this fix modifies the group permissions to allow the root group (gid 0) to write into it. This is a simple solution that allows to run Milvus on OpenShift without adding security constraints, use special ServiceAccounts or whatever. This should also not impact any other kubernetes platform as it's a simple group permission change, nothing regarding the userid. Note: Other actions are necessary to properly deploy the full stack (Minio, Pulsar,...) on OpenShift. I will document them in the helm chart project. Fixes milvus-io#25565 Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com>
…o#30775) OpenShift runs Pods with a random uid and gid 0. As Milvus needs to write into the /milvus directory, this fix modifies the group permissions to allow the root group (gid 0) to write into it. This is a simple solution that allows to run Milvus on OpenShift without adding security constraints, use special ServiceAccounts or whatever. This should also not impact any other kubernetes platform as it's a simple group permission change, nothing regarding the userid. Note: Other actions are necessary to properly deploy the full stack (Minio, Pulsar,...) on OpenShift. I will document them in the helm chart project. Fixes milvus-io#25565 Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com> Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
…o#30775) OpenShift runs Pods with a random uid and gid 0. As Milvus needs to write into the /milvus directory, this fix modifies the group permissions to allow the root group (gid 0) to write into it. This is a simple solution that allows to run Milvus on OpenShift without adding security constraints, use special ServiceAccounts or whatever. This should also not impact any other kubernetes platform as it's a simple group permission change, nothing regarding the userid. Note: Other actions are necessary to properly deploy the full stack (Minio, Pulsar,...) on OpenShift. I will document them in the helm chart project. Fixes milvus-io#25565 Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com> Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
OpenShift runs Pods with a random uid and gid 0.
As Milvus needs to write into the /milvus directory, this fix modifies the group permissions to allow the root group (gid 0) to write into it.
This is a simple solution that allows to run Milvus on OpenShift without adding security constraints, use special ServiceAccounts or whatever. This should also not impact any other kubernetes platform as it's a simple group permission change, nothing regarding the userid.
Note: Other actions are necessary to properly deploy the full stack (Minio, Pulsar,...) on OpenShift. I will document them in the helm chart project.
Fixes #25565