fix: fix permissions on /milvus for OpenShift compatibility #30775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @guimou! It looks like this is your first PR to milvus-io/milvus 🎉 |
|
@guimou Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com>
guimou
force-pushed
the
openshift-compatible-container
branch
from
abfe4ac
to
da40d81
Compare
mergify
bot
added
dco-passed
1 task
|
@LoveEachDay take a look? |
|
@guimou Thanks for fixing this issue. @LoveEachDay Can you let me know when the next release is scheduled and if this fix will be included? Thank you. |
|
Hi @arunkumara8, we usually release minor version every 2 or 3 weeks. this fix will be included if its cherry-pick to v2.3 branch is merged. |
|
rerun ut |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30775 +/- ##
==========================================
+ Coverage 80.48% 80.72% +0.23%
==========================================
Files 964 964
Lines 137160 137161 +1
==========================================
+ Hits 110400 110719 +319
+ Misses 23036 22727 -309
+ Partials 3724 3715 -9 |
|
/assign @czs007 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, guimou, LoveEachDay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
haorenfsa
pushed a commit
to haorenfsa/milvus
that referenced
this pull request
Feb 29, 2024
…o#30775) OpenShift runs Pods with a random uid and gid 0. As Milvus needs to write into the /milvus directory, this fix modifies the group permissions to allow the root group (gid 0) to write into it. This is a simple solution that allows to run Milvus on OpenShift without adding security constraints, use special ServiceAccounts or whatever. This should also not impact any other kubernetes platform as it's a simple group permission change, nothing regarding the userid. Note: Other actions are necessary to properly deploy the full stack (Minio, Pulsar,...) on OpenShift. I will document them in the helm chart project. Fixes milvus-io#25565 Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com>
haorenfsa
pushed a commit
to haorenfsa/milvus
that referenced
this pull request
Feb 29, 2024
…o#30775) OpenShift runs Pods with a random uid and gid 0. As Milvus needs to write into the /milvus directory, this fix modifies the group permissions to allow the root group (gid 0) to write into it. This is a simple solution that allows to run Milvus on OpenShift without adding security constraints, use special ServiceAccounts or whatever. This should also not impact any other kubernetes platform as it's a simple group permission change, nothing regarding the userid. Note: Other actions are necessary to properly deploy the full stack (Minio, Pulsar,...) on OpenShift. I will document them in the helm chart project. Fixes milvus-io#25565 Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com>
haorenfsa
pushed a commit
to haorenfsa/milvus
that referenced
this pull request
Mar 4, 2024
…o#30775) OpenShift runs Pods with a random uid and gid 0. As Milvus needs to write into the /milvus directory, this fix modifies the group permissions to allow the root group (gid 0) to write into it. This is a simple solution that allows to run Milvus on OpenShift without adding security constraints, use special ServiceAccounts or whatever. This should also not impact any other kubernetes platform as it's a simple group permission change, nothing regarding the userid. Note: Other actions are necessary to properly deploy the full stack (Minio, Pulsar,...) on OpenShift. I will document them in the helm chart project. Fixes milvus-io#25565 Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com> Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
haorenfsa
pushed a commit
to haorenfsa/milvus
that referenced
this pull request
Mar 4, 2024
…o#30775) OpenShift runs Pods with a random uid and gid 0. As Milvus needs to write into the /milvus directory, this fix modifies the group permissions to allow the root group (gid 0) to write into it. This is a simple solution that allows to run Milvus on OpenShift without adding security constraints, use special ServiceAccounts or whatever. This should also not impact any other kubernetes platform as it's a simple group permission change, nothing regarding the userid. Note: Other actions are necessary to properly deploy the full stack (Minio, Pulsar,...) on OpenShift. I will document them in the helm chart project. Fixes milvus-io#25565 Signed-off-by: Guillaume Moutier <guillaume.moutier@gmail.com> Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenShift runs Pods with a random uid and gid 0.
As Milvus needs to write into the /milvus directory, this fix modifies the group permissions to allow the root group (gid 0) to write into it.
This is a simple solution that allows to run Milvus on OpenShift without adding security constraints, use special ServiceAccounts or whatever. This should also not impact any other kubernetes platform as it's a simple group permission change, nothing regarding the userid.
Note: Other actions are necessary to properly deploy the full stack (Minio, Pulsar,...) on OpenShift. I will document them in the helm chart project.
Fixes #25565