Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.3] make the watch dm channel request better compatibility #30954

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Feb 29, 2024

pr: #30952
issue: #30938

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Feb 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 29, 2024
Copy link
Contributor

mergify bot commented Feb 29, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented Feb 29, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 29, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 29, 2024

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 29, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.18%. Comparing base (2f76303) to head (f9f02f1).
Report is 5 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30954      +/-   ##
==========================================
- Coverage   82.20%   82.18%   -0.03%     
==========================================
  Files         841      841              
  Lines      121458   121463       +5     
==========================================
- Hits        99847    99821      -26     
- Misses      18385    18407      +22     
- Partials     3226     3235       +9     
Files Coverage Δ
internal/querycoordv2/server.go 81.86% <100.00%> (+0.15%) ⬆️
internal/querycoordv2/session/node_manager.go 100.00% <100.00%> (ø)
internal/querycoordv2/task/utils.go 91.94% <100.00%> (+0.10%) ⬆️
internal/querynodev2/cluster/worker.go 88.50% <100.00%> (-1.40%) ⬇️
internal/querycoordv2/task/executor.go 69.04% <57.14%> (-0.35%) ⬇️

... and 21 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 1, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ef84d40 into milvus-io:2.3 Mar 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants