Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [Cherry-pick] Add ListIndexes API from datacoord (#31104) #31150

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #31104
See also #31103

This PR add listIndexes API for datacoor server to list all indexes for provided collection.
Comparing to the existing DescribeIndex API, the new one does NOT check the segment index building progress to ease the burden when invoking it

See also milvus-io#31103

This PR add `listIndexes` API for datacoor server to list all indexes
for provided collection.
Comparing to the existing `DescribeIndex` API, the new one does NOT
check the segment index building progress to ease the burden when
invoking it

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added area/internal-api size/L Denotes a PR that changes 100-499 lines. labels Mar 8, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 8, 2024
Copy link
Contributor

mergify bot commented Mar 8, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (c37b779) to head (395beee).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31150      +/-   ##
==========================================
- Coverage   82.22%   82.21%   -0.01%     
==========================================
  Files         844      844              
  Lines      122167   122203      +36     
==========================================
+ Hits       100448   100472      +24     
- Misses      18478    18494      +16     
+ Partials     3241     3237       -4     
Files Coverage Δ
internal/datacoord/index_service.go 95.37% <100.00%> (+0.22%) ⬆️
internal/distributed/datacoord/client/client.go 96.99% <100.00%> (+0.02%) ⬆️
internal/distributed/datacoord/service.go 87.85% <100.00%> (+0.09%) ⬆️

... and 17 files with indirect coverage changes

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia
Copy link
Contributor Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Mar 8, 2024

refresh

✅ Pull request refreshed

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 11, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 3c90475 into milvus-io:2.3 Mar 11, 2024
14 checks passed
@yanliang567 yanliang567 added this to the 2.3.12 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants