Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add more metrics (#31271) #31511

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

longjiquan
Copy link
Contributor

@longjiquan longjiquan commented Mar 22, 2024

/kind improvement
pr: #31271
fix: #31272

This pr add more metrics, which are:

Slow query count, which the duration considered as slow can be configurable;
Number of deleted entities;
Number of entities per collection;
Number of loaded entities per collection;
Number of indexed entities;
Number of indexed entities, per collection, per index and whether it's a vetor index;
Quota states (LongTimeTickDelay, MemoryExhuasted, DiskQuotaExhuasted) per database;

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 22, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 22, 2024
Copy link
Contributor

mergify bot commented Mar 22, 2024

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 71.77914% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 82.20%. Comparing base (c8658d1) to head (9a1038a).
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31511      +/-   ##
==========================================
- Coverage   82.24%   82.20%   -0.04%     
==========================================
  Files         844      844              
  Lines      122408   122691     +283     
==========================================
+ Hits       100669   100859     +190     
- Misses      18501    18579      +78     
- Partials     3238     3253      +15     
Files Coverage Δ
internal/datacoord/meta.go 88.80% <100.00%> (+0.01%) ⬆️
internal/datacoord/metrics_info.go 94.68% <100.00%> (+1.13%) ⬆️
pkg/metrics/metrics.go 100.00% <ø> (ø)
pkg/metrics/proxy_metrics.go 100.00% <100.00%> (ø)
pkg/metrics/rootcoord_metrics.go 100.00% <100.00%> (ø)
pkg/util/metricsinfo/metrics_info.go 100.00% <ø> (ø)
pkg/util/paramtable/component_param.go 98.34% <100.00%> (+<0.01%) ⬆️
internal/querynodev2/metrics_info.go 72.35% <65.00%> (-0.68%) ⬇️
internal/proxy/impl.go 85.52% <0.00%> (-0.20%) ⬇️
internal/rootcoord/quota_center.go 87.20% <60.60%> (-3.58%) ⬇️

... and 18 files with indirect coverage changes

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Copy link
Contributor

mergify bot commented Mar 22, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented Mar 22, 2024

/run-cpu-e2e

@czs007
Copy link
Contributor

czs007 commented Mar 22, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 22, 2024
@sre-ci-robot sre-ci-robot merged commit ab059bb into milvus-io:2.3 Mar 22, 2024
13 of 14 checks passed
@longjiquan longjiquan deleted the cp-31271 branch March 22, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants