Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Make target observer auto/manual task mutual exclusive (#31584) #31602

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #31584
See also #30867

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Mar 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.77%. Comparing base (f1a108c) to head (f2727fa).
Report is 16 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31602      +/-   ##
==========================================
- Coverage   80.80%   80.77%   -0.03%     
==========================================
  Files         965      970       +5     
  Lines      136613   137721    +1108     
==========================================
+ Hits       110389   111251     +862     
- Misses      22508    22750     +242     
- Partials     3716     3720       +4     
Files Coverage Δ
internal/querycoordv2/observers/target_observer.go 80.47% <100.00%> (-0.25%) ⬇️

... and 92 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 26, 2024
@weiliu1031
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants