Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make target observer auto/manual task mutual exclusive #31584

Merged

Conversation

congqixia
Copy link
Contributor

See also #30867

See also milvus-io#30867

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Mar 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 25, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.94%. Comparing base (0c868b6) to head (596576c).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31584      +/-   ##
==========================================
- Coverage   80.95%   80.94%   -0.02%     
==========================================
  Files         977      977              
  Lines      138781   138814      +33     
==========================================
+ Hits       112353   112362       +9     
- Misses      22671    22695      +24     
  Partials     3757     3757              
Files Coverage Δ
internal/querycoordv2/observers/target_observer.go 79.23% <100.00%> (+0.96%) ⬆️

... and 27 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 26, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 73858b2 into milvus-io:master Mar 26, 2024
14 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Mar 26, 2024
congqixia added a commit to congqixia/milvus that referenced this pull request Mar 26, 2024
chyezh pushed a commit to chyezh/milvus that referenced this pull request Mar 27, 2024
sre-ci-robot pushed a commit that referenced this pull request Mar 27, 2024
…1584) (#31602)

Cherry-pick from master
pr: #31584
See also #30867

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Mar 27, 2024
…1584) (#31603)

Cherry-pick from master
pr: #31584
See also #30867

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants