enhance: [2.4] Save collection targets by batches (#31616) #31632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
See also milvus-io#28491 milvus-io#31240 When colleciton number is large, querycoord saves collection target one by one, which is slow and may block querycoord exits. In local run, 500 collections scenario may lead to about 40 seconds saving collection targets. This PR changes the `SaveCollectionTarget` interface into batch one and organizes the collection in 16 per bundle batches to accelerate this procedure. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #31632 +/- ##
==========================================
- Coverage 80.85% 80.70% -0.16%
==========================================
Files 970 970
Lines 137715 137761 +46
==========================================
- Hits 111354 111175 -179
- Misses 22647 22875 +228
+ Partials 3714 3711 -3
|
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
/lgtm |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Apr 17, 2024
See also milvus-io#31632 Release conc.Pool after usage to clean worker and stop background purge and ticktock. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Apr 18, 2024
See also milvus-io#31632 Release conc.Pool after usage to clean worker and stop background purge and ticktock. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Apr 19, 2024
See also #31632 Release conc.Pool after usage to clean worker and stop background purge and ticktock. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Apr 19, 2024
See also milvus-io#31632 Release conc.Pool after usage to clean worker and stop background purge and ticktock. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from master
pr: #31616
See also #28491 #31240
When colleciton number is large, querycoord saves collection target one by one, which is slow and may block querycoord exits.
In local run, 500 collections scenario may lead to about 40 seconds saving collection targets.
This PR changes the
SaveCollectionTargetinterface into batch one and organizes the collection in 16 per bundle batches to accelerate this procedure.