Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Manual release pool after save targets (#32358) #32457

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Apr 19, 2024

Cherry-pick from master
pr: #32358
See also #31632

Release conc.Pool after usage to clean worker and stop background purge and ticktock.

See also milvus-io#31632

Release conc.Pool after usage to clean worker and stop background purge
and ticktock.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 19, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Apr 19, 2024
Copy link
Contributor

mergify bot commented Apr 19, 2024

@congqixia Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement and removed do-not-merge/missing-related-pr labels Apr 19, 2024
Copy link
Contributor

mergify bot commented Apr 19, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (eba9c74) to head (48b8aea).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32457      +/-   ##
==========================================
- Coverage   81.62%   81.62%   -0.01%     
==========================================
  Files         976      976              
  Lines      120017   120018       +1     
==========================================
- Hits        97968    97962       -6     
- Misses      18323    18330       +7     
  Partials     3726     3726              
Files Coverage Δ
internal/querycoordv2/meta/target_manager.go 88.14% <100.00%> (+0.03%) ⬆️

... and 27 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Apr 19, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 19, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 8b0d445 into milvus-io:2.4 Apr 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants