Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Pick]Check whether the DataType of the column is legal #31698

Merged
merged 2 commits into from Mar 29, 2024
Merged

fix: [Pick]Check whether the DataType of the column is legal #31698

merged 2 commits into from Mar 29, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #31696
master pr: #31697

@xiaocai2333
Check whether the DataType of the column is legal
c07f2a2 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 28, 2024
@xiaocai2333 xiaocai2333 mentioned this pull request Mar 28, 2024
Merged
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 28, 2024
@xiaocai2333 xiaocai2333 changed the title fix: Check whether the DataType of the column is legal fix: [Pick]Check whether the DataType of the column is legal Mar 28, 2024
@xiaocai2333
fix ut
f490d00 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.71%. Comparing base (bd6f123) to head (f490d00).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31698      +/-   ##
==========================================
- Coverage   80.81%   80.71%   -0.10%     
==========================================
  Files         974      974              
  Lines      137886   137892       +6     
==========================================
- Hits       111429   111301     -128     
- Misses      22746    22874     +128     
- Partials     3711     3717       +6
Files Coverage Δ
internal/rootcoord/create_collection_task.go 95.04% <100.00%> (-0.68%) ⬇️

... and 34 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 28, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

sre-ci-robot pushed a commit that referenced this pull request Mar 29, 2024
@xiaocai2333
fix: [Pick]Check whether the DataType of the column is legal (#31699)
4a4a4b1 
issue: #31696 
master pr: #31697 
2.4 pr: #31698

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c9692b5 into milvus-io:2.4 Mar 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiaocai2333 @xiaofan-luan @sre-ci-robot