Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Pick]Check whether the DataType of the column is legal #31699

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #31696
master pr: #31697
2.4 pr: #31698

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 28, 2024
@xiaocai2333 xiaocai2333 changed the title fix: Check whether the DataType of the column is legal fix: [Pick]Check whether the DataType of the column is legal Mar 28, 2024
@czs007 czs007 added this to the 2.3.13 milestone Mar 28, 2024
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.35%. Comparing base (8713765) to head (a672645).
Report is 5 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31699      +/-   ##
==========================================
- Coverage   82.37%   82.35%   -0.02%     
==========================================
  Files         848      848              
  Lines      124489   124545      +56     
==========================================
+ Hits       102545   102567      +22     
- Misses      18666    18697      +31     
- Partials     3278     3281       +3     
Files Coverage Δ
internal/rootcoord/create_collection_task.go 92.05% <100.00%> (-1.40%) ⬇️

... and 26 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 28, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4a4a4b1 into milvus-io:2.3 Mar 29, 2024
14 checks passed
@xiaocai2333 xiaocai2333 deleted the verify_field_data_type branch May 10, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants