Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: update shard leader cache when leader location changed #32470

Merged
merged 2 commits into from
May 8, 2024
Merged

enhance: update shard leader cache when leader location changed #32470

merged 2 commits into from
May 8, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #32466

this PR enhance that when shard location changed, update proxy's shard leader cache. in case of query node failover case, proxy can find replica recover

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Apr 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 19, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited

Codecov Report

Attention: Patch coverage is 85.89212% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 81.75%. Comparing base (6289f3a) to head (53859f4).
Report is 45 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32470      +/-   ##
==========================================
+ Coverage   81.72%   81.75%   +0.02%     
==========================================
  Files         998      999       +1     
  Lines      124209   124338     +129     
==========================================
+ Hits       101513   101654     +141     
+ Misses      18822    18809      -13     
- Partials     3874     3875       +1
Files Coverage Δ
internal/distributed/proxy/client/client.go 96.77% <100.00%> (+0.10%) ⬆️
internal/distributed/proxy/service.go 84.01% <100.00%> (+0.04%) ⬆️
internal/proxy/impl.go 86.51% <100.00%> (+0.04%) ⬆️
internal/proxy/meta_cache.go 94.62% <100.00%> (+0.39%) ⬆️
internal/querycoordv2/checkers/channel_checker.go 84.55% <100.00%> (ø)
internal/querycoordv2/handlers.go 72.45% <ø> (-0.25%) ⬇️
internal/querycoordv2/meta/leader_view_manager.go 96.99% <100.00%> (+0.44%) ⬆️
internal/querycoordv2/services.go 86.31% <100.00%> (+1.39%) ⬆️
internal/querycoordv2/server.go 83.53% <88.23%> (+0.16%) ⬆️
...al/querycoordv2/observers/leader_cache_observer.go 86.95% <86.95%> (ø)
... and 2 more

... and 26 files with indirect coverage changes

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Apr 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 22, 2024

@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Apr 22, 2024
@weiliu1031 weiliu1031 force-pushed the update_shard_leader_cache branch 2 times, most recently from 9946b16 to 0b8550c Compare April 23, 2024 09:14
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 23, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 24, 2024
@mergify mergify bot removed the ci-passed label Apr 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 25, 2024
@mergify mergify bot removed the ci-passed label Apr 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 28, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 28, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the update_shard_leader_cache branch 2 times, most recently from 977f56e to f4991d9 Compare April 28, 2024 13:35
@mergify mergify bot added the ci-passed label Apr 29, 2024
@weiliu1031
enhance: update shard leader cache when leader location changed
ad1aa21 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031
fix review comment
53859f4 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@mergify mergify bot added ci-passed and removed ci-passed labels Apr 29, 2024
congqixia
congqixia approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ba02d54 into milvus-io:master May 8, 2024
15 checks passed
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request May 10, 2024
@weiliu1031
enhance: update shard leader cache when leader location changed (milv…
72a014c 
…us-io#32470)

issue: milvus-io#32466

this PR enhance that when shard location changed, update proxy's shard
leader cache. in case of query node failover case, proxy can find
replica recover

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@czs007 czs007 Awaiting requested review from czs007

Assignees

@congqixia congqixia

Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weiliu1031 @sre-ci-robot @congqixia