enhance: check the partition num when creating collection with partition key #32670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@SimFG E2e jenkins job failed, comment |
…ion key Signed-off-by: SimFG <bang.fu@zilliz.com>
SimFG
force-pushed
the
master-partition-key
branch
from
5d1d265
to
e5ce03c
Compare
sre-ci-robot
added
area/test
sig/testing
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32670 +/- ##
==========================================
+ Coverage 81.72% 81.75% +0.03%
==========================================
Files 998 998
Lines 124044 124094 +50
==========================================
+ Hits 101374 101454 +80
+ Misses 18799 18786 -13
+ Partials 3871 3854 -17
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, SimFG The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
SimFG
added a commit
to SimFG/milvus
that referenced
this pull request
May 7, 2024
…partition key (milvus-io#32670) issue: milvus-io#30577 Signed-off-by: SimFG <bang.fu@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
May 7, 2024
/kind improvement issue: #32591 pr: #32775 #32670 #32680 fix: skip to check auto id when inserting data (#32775) enhance: check the partition num when creating collection with partition key (#32670) enhance: add the config to control the way when fail to init plugin (#32680) --------- Signed-off-by: SimFG <bang.fu@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #30577