-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: check the partition num when creating collection with partition key #32670
Conversation
@SimFG E2e jenkins job failed, comment |
…ion key Signed-off-by: SimFG <bang.fu@zilliz.com>
5d1d265
to
e5ce03c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32670 +/- ##
==========================================
+ Coverage 81.72% 81.75% +0.03%
==========================================
Files 998 998
Lines 124044 124094 +50
==========================================
+ Hits 101374 101454 +80
+ Misses 18799 18786 -13
+ Partials 3871 3854 -17
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, SimFG The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…partition key (milvus-io#32670) issue: milvus-io#30577 Signed-off-by: SimFG <bang.fu@zilliz.com>
/kind improvement issue: #32591 pr: #32775 #32670 #32680 fix: skip to check auto id when inserting data (#32775) enhance: check the partition num when creating collection with partition key (#32670) enhance: add the config to control the way when fail to init plugin (#32680) --------- Signed-off-by: SimFG <bang.fu@zilliz.com>
issue: #30577