Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.3] add the skip auto id and partition key check config #32671

Merged
merged 1 commit into from Apr 29, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Apr 28, 2024

/kind improvement
issue: #32591
pr: #32592

Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Apr 28, 2024
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 28, 2024
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (114e305) to head (e6f2835).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #32671      +/-   ##
==========================================
+ Coverage   83.04%   83.09%   +0.04%     
==========================================
  Files         850      850              
  Lines      106508   106523      +15     
==========================================
+ Hits        88450    88510      +60     
+ Misses      14759    14710      -49     
- Partials     3299     3303       +4     
Files Coverage Δ
internal/proxy/util.go 91.53% <100.00%> (-0.19%) ⬇️
pkg/util/paramtable/component_param.go 98.26% <100.00%> (+0.01%) ⬆️

... and 20 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 28, 2024
@yanliang567 yanliang567 added this to the 2.3.15 milestone Apr 28, 2024
@jaime0815
Copy link
Contributor

/lgtm

@czs007
Copy link
Contributor

czs007 commented Apr 29, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3a7154b into milvus-io:2.3 Apr 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants