Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add the skip auto id and partition key check config #32592

Merged
merged 1 commit into from
Apr 29, 2024
Merged

enhance: add the skip auto id and partition key check config #32592

merged 1 commit into from
Apr 29, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Apr 25, 2024

/kind improvement
issue: #32591

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Apr 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG
enhance: add the skip auto id and partition key check config
b6abfd4 
Signed-off-by: SimFG <bang.fu@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Apr 25, 2024

/run-cpu-e2e

@SimFG SimFG mentioned this pull request Apr 25, 2024
Merged
@SimFG
Copy link
Contributor Author

SimFG commented Apr 25, 2024

rerun ut

@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.74%. Comparing base (281a583) to head (b6abfd4).
Report is 41 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32592      +/-   ##
==========================================
- Coverage   81.76%   81.74%   -0.03%     
==========================================
  Files         999      999              
  Lines      124073   124273     +200     
==========================================
+ Hits       101453   101584     +131     
- Misses      18746    18819      +73     
+ Partials     3874     3870       -4
Files Coverage Δ
internal/proxy/util.go 90.57% <100.00%> (+0.02%) ⬆️
pkg/util/paramtable/component_param.go 98.43% <100.00%> (+<0.01%) ⬆️

... and 35 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 25, 2024
@SimFG SimFG mentioned this pull request Apr 28, 2024
Merged
@jaime0815
Copy link
Contributor

/lgtm

sre-ci-robot pushed a commit that referenced this pull request Apr 29, 2024
@SimFG
enhance: [2.4] add the skip auto id and partition key check config (#…
5da6db9 
…32597)

/kind improvement
issue: #32591
pr: #32592

Signed-off-by: SimFG <bang.fu@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Apr 29, 2024
@SimFG
enhance: [2.3] add the skip auto id and partition key check config (#…
3a7154b 
…32671)

/kind improvement
issue: #32591
pr: #32592

Signed-off-by: SimFG <bang.fu@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented Apr 29, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 09cd56d into milvus-io:master Apr 29, 2024
15 checks passed
@SimFG SimFG mentioned this pull request May 6, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request May 7, 2024
@SimFG
fix: skip to check auto id when inserting data (#32775)
48fb831 
/kind improvement
issue: #32591
related pr: #32592

Signed-off-by: SimFG <bang.fu@zilliz.com>
SimFG added a commit to SimFG/milvus that referenced this pull request May 7, 2024
@SimFG
fix: [2.4] skip to check auto id when inserting data (milvus-io#32775)
b94e964 
/kind improvement
issue: milvus-io#32591
related pr: milvus-io#32592

Signed-off-by: SimFG <bang.fu@zilliz.com>
This was referenced May 7, 2024
Merged
Merged
sre-ci-robot pushed a commit that referenced this pull request May 8, 2024
@SimFG
fix: [2.3] skip to check auto id when inserting data (#32840)
f72e89b 
/kind improvement
issue: #32591
pr: #32775
related pr: #32592

Signed-off-by: SimFG <bang.fu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@jaime0815 jaime0815

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SimFG @jaime0815 @czs007 @sre-ci-robot