Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unify querynode metrics cleanup in collection release #32805

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: Unify querynode metrics cleanup in collection release #32805

merged 1 commit into from
May 7, 2024

Conversation

congqixia
Copy link
Contributor

Related to #32803

@congqixia
fix: Unify querynode metrics cleanup in collection release
9f64a55 
Related to milvus-io#32803

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 7, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 7, 2024
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (4de063a) to head (9f64a55).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32805      +/-   ##
==========================================
+ Coverage   81.73%   81.75%   +0.01%     
==========================================
  Files        1002     1002              
  Lines      125438   125433       -5     
==========================================
+ Hits       102532   102551      +19     
+ Misses      18999    18985      -14     
+ Partials     3907     3897      -10
Files Coverage Δ
internal/querynodev2/pipeline/pipeline.go 100.00% <ø> (ø)
internal/querynodev2/segments/collection.go 91.26% <100.00%> (-2.07%) ⬇️
pkg/metrics/querynode_metrics.go 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 7, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit efa0c73 into milvus-io:master May 7, 2024
15 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request May 7, 2024
@congqixia
fix: Unify querynode metrics cleanup in collection release (milvus-io…
b35f05d 
…#32805)

Related to milvus-io#32803

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this pull request May 7, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request May 8, 2024
@congqixia
fix: [2.4] Unify querynode metrics cleanup in collection release (#32805
311d66c 
) (#32825)

Cherry-pick from master
pr: #32805 
Related to #32803

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoiasd aoiasd Awaiting requested review from aoiasd

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@weiliu1031 weiliu1031

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@congqixia @sre-ci-robot @weiliu1031