Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Unify querynode metrics cleanup in collection release (#32805) #32825

Merged
merged 1 commit into from
May 8, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #32805
Related to #32803

…#32805)

Related to milvus-io#32803

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 7, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (46acc07) to head (b35f05d).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32825      +/-   ##
==========================================
+ Coverage   81.79%   81.80%   +0.01%     
==========================================
  Files         998      999       +1     
  Lines      124419   124467      +48     
==========================================
+ Hits       101764   101823      +59     
+ Misses      18781    18768      -13     
- Partials     3874     3876       +2     
Files Coverage Δ
internal/querynodev2/pipeline/pipeline.go 100.00% <ø> (ø)
internal/querynodev2/segments/collection.go 91.26% <100.00%> (-0.59%) ⬇️
pkg/metrics/querynode_metrics.go 100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 8, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 311d66c into milvus-io:2.4 May 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants