New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: async cgo utility #33133

Merged

sre-ci-robot merged 7 commits into milvus-io:master from chyezh:feat_async_cgo

Jun 9, 2024

Contributor

chyezh commented May 17, 2024

issue: #30926, #33132

implement future-based cgo utility.

sre-ci-robot requested review from bigsheeper and czs007

May 17, 2024 08:22

sre-ci-robot added size/XXL area/compilation labels

mergify bot added dco-passed kind/enhancement labels

Contributor

mergify bot commented May 17, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

Contributor

mergify bot commented May 17, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented May 19, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

chyezh force-pushed the feat_async_cgo branch 2 times, most recently from 4506cda to e22eca1 Compare

May 19, 2024 15:23

codecov bot commented May 20, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 82.02247% with 64 lines in your changes missing coverage. Please review.

Project coverage is 81.38%. Comparing base (60baaed) to head (036a8ec).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #33133      +/-   ##
==========================================
+ Coverage   81.23%   81.38%   +0.15%     
==========================================
  Files        1029     1038       +9     
  Lines      132215   133169     +954     
==========================================
+ Hits       107399   108377     +978     
+ Misses      20766    20725      -41     
- Partials     4050     4067      +17

Files	Coverage Δ
internal/core/src/common/EasyAssert.h	`83.33% <100.00%> (-0.88%)`	⬇️
internal/util/cgo/errors.go	`100.00% <100.00%> (ø)`
internal/util/cgo/futures_test_case.go	`100.00% <100.00%> (ø)`
internal/util/cgo/options.go	`100.00% <100.00%> (ø)`
internal/util/cgo/pool.go	`100.00% <100.00%> (ø)`
internal/util/cgo/state.go	`100.00% <100.00%> (ø)`
pkg/util/merr/errors.go	`86.95% <ø> (ø)`
internal/core/src/futures/Ready.h	`96.29% <96.29%> (ø)`
internal/util/cgo/futures.go	`98.48% <98.48%> (ø)`
internal/util/cgo/manager_active.go	`94.44% <94.44%> (ø)`
... and 6 more

... and 234 files with indirect coverage changes

chyezh force-pushed the feat_async_cgo branch 2 times, most recently from 6d7e8cb to de513be Compare

May 20, 2024 06:56

chyezh mentioned this pull request

enhance: async cgo utility #33167

Closed

Contributor

mergify bot commented May 20, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

chyezh force-pushed the feat_async_cgo branch from 45c3687 to a541f2b Compare

May 20, 2024 09:50

mergify bot added needs-dco and removed dco-passed labels

Contributor

mergify bot commented May 20, 2024

@chyezh Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify bot added dco-passed and removed needs-dco labels

chyezh force-pushed the feat_async_cgo branch from a541f2b to edbc02f Compare

May 20, 2024 10:05

Contributor

mergify bot commented May 20, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

chyezh force-pushed the feat_async_cgo branch from b6d34a7 to e696c13 Compare

May 20, 2024 13:21

Contributor

mergify bot commented May 20, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented May 20, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

chyezh force-pushed the feat_async_cgo branch from e696c13 to 94f0b77 Compare

May 20, 2024 15:49

chyezh mentioned this pull request

[Bug]: [benchmark][cluster] Index Node disconnected from etcd and restarted multiple times #30915

Closed

1 task

mergify bot added the ci-passed label

sre-ci-robot added the approved label

sre-ci-robot merged commit f53ab54 into milvus-io:master

15 checks passed

chyezh deleted the feat_async_cgo branch

June 13, 2024 07:34

sre-ci-robot pushed a commit that referenced this pull request


          enhance: async search and retrieve in cgo (#33228)

259a682

issue: #30926, #33132
related pr: #33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

016adeb

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

4f326ea

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh mentioned this pull request

enhance: async search and retrieve in cgo #34200

Merged

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

b0c9327

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

cb9138d

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

f5fca99

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

3f66355

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

90d2c18

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

7b04667

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

2d55649

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

b3eb5b9

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

aaf7b34

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

5fd3594

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

c01d0be

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

64efc80

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

7a8edf8

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

48208ba

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

dc04f81

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

5728c16

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

8d47512

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async cgo utility (milvus-io#33133)

5fc91d3

issue: milvus-io#30926, milvus-io#33132

- implement future-based cgo utility.

---------

Signed-off-by: chyezh <chyezh@outlook.com>

chyezh added a commit to chyezh/milvus that referenced this pull request


          enhance: async search and retrieve in cgo (milvus-io#33228)

5b25b9c

issue: milvus-io#30926, milvus-io#33132
related pr: milvus-io#33133

---------

Signed-off-by: chyezh <chyezh@outlook.com>

sre-ci-robot pushed a commit that referenced this pull request


          enhance: async search and retrieve in cgo (#34200)

a1a0a56

issue: #33132
pr: #33133
other pr: #33228, #34084, #33946

- implement future-based cgo utility
- async search and retrieve in cgo
- modify gc configuration document

---------

Signed-off-by: chyezh <chyezh@outlook.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/compilation ci-passed dco-passed kind/enhancement lgtm size/XXL