Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix filtering by partition key fails for importing data #33274

Merged
merged 3 commits into from
May 23, 2024

Conversation

bigsheeper
Copy link
Contributor

Before executing the import, partition IDs should be reordered according to partition names. Otherwise, the data might be hashed to the wrong partition during import. This PR corrects this error.

issue: #33237

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing test/integration integration test labels May 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 22, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.18%. Comparing base (fc765c6) to head (f5a8949).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33274      +/-   ##
==========================================
- Coverage   82.19%   82.18%   -0.02%     
==========================================
  Files        1009     1009              
  Lines      128871   128844      -27     
==========================================
- Hits       105931   105894      -37     
- Misses      18956    18962       +6     
- Partials     3984     3988       +4     
Files Coverage Δ
internal/proxy/msg_pack.go 74.39% <100.00%> (ø)
internal/proxy/util.go 89.74% <ø> (+0.55%) ⬆️
internal/proxy/impl.go 86.39% <25.00%> (-0.04%) ⬇️

... and 37 files with indirect coverage changes

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label May 22, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented May 23, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 23, 2024
@sre-ci-robot sre-ci-robot merged commit 9ff023e into milvus-io:master May 23, 2024
14 of 15 checks passed
sre-ci-robot pushed a commit that referenced this pull request May 23, 2024
…#33277)

Before executing the import, partition IDs should be reordered according
to partition names. Otherwise, the data might be hashed to the wrong
partition during import. This PR corrects this error.

issue: #33237

pr: #33274

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants