Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix filtering by partition key fails for importing data (#33274) #33277

Merged
merged 4 commits into from
May 23, 2024

Conversation

bigsheeper
Copy link
Contributor

Before executing the import, partition IDs should be reordered according to partition names. Otherwise, the data might be hashed to the wrong partition during import. This PR corrects this error.

issue: #33237

pr: #33274

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. labels May 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 22, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented May 22, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.19%. Comparing base (3c31499) to head (cec79bc).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33277      +/-   ##
==========================================
+ Coverage   82.16%   82.19%   +0.03%     
==========================================
  Files         996      996              
  Lines      128293   128281      -12     
==========================================
+ Hits       105413   105445      +32     
+ Misses      18912    18868      -44     
  Partials     3968     3968              
Files Coverage Δ
internal/proxy/msg_pack.go 74.39% <100.00%> (ø)
internal/proxy/util.go 91.32% <ø> (+0.57%) ⬆️
internal/proxy/impl.go 86.39% <25.00%> (-0.04%) ⬇️

... and 27 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented May 23, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 23, 2024
@sre-ci-robot sre-ci-robot merged commit ad4c197 into milvus-io:2.4 May 23, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants