Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace removeWithPrefix with remove to avoid delete redundantly #33328

Merged
merged 2 commits into from
May 31, 2024
Merged

fix: replace removeWithPrefix with remove to avoid delete redundantly #33328

merged 2 commits into from
May 31, 2024

Conversation

smellthemoon
Copy link
Contributor

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 23, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon smellthemoon force-pushed the multi-remove branch 2 times, most recently from 60fe895 to d8d89fe Compare May 24, 2024 06:31
@mergify Mergify
Copy link
Contributor

mergify bot commented May 24, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

fix: replace removeWithPrefix with remove to avoid delete redundantly
a227f8c 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@codecov Codecov
Copy link

codecov bot commented May 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 82.21%. Comparing base (a26d6cd) to head (bf0c2e1).
Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #33328   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files        1012     1012           
  Lines      129266   129289   +23     
=======================================
+ Hits       106276   106298   +22     
- Misses      19012    19013    +1     
  Partials     3978     3978
Files Coverage Δ
internal/kv/kv.go 0.00% <ø> (ø)
internal/metastore/kv/rootcoord/kv_catalog.go 89.36% <88.88%> (-0.05%) ⬇️
internal/metastore/kv/rootcoord/suffix_snapshot.go 81.63% <73.07%> (-0.68%) ⬇️

... and 35 files with indirect coverage changes

fix ut
bf0c2e1 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
longjiquan
longjiquan reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@longjiquan
Copy link
Contributor

Very nice! With this API, we can control the garbage collection of collection meta more conveniently.

congqixia
congqixia approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 31, 2024
@sre-ci-robot sre-ci-robot merged commit 2c7bb0b into milvus-io:master May 31, 2024
14 of 15 checks passed
@czs007 czs007 added PR | need cherry-pick need cherry pick to other branches and removed PR | need cherry-pick need cherry pick to other branches labels Jun 26, 2024
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@smellthemoon @yellow-shine
fix: replace removeWithPrefix with remove to avoid delete redundantly (…
0858fe4 
…milvus-io#33328)

milvus-io#33288

---------

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longjiquan longjiquan longjiquan left review comments

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@longjiquan longjiquan

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@smellthemoon @longjiquan @sre-ci-robot @congqixia @czs007 @yanliang567