-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: wrong operate to drop collection/database etc. with prefix in snapshot #33288
Comments
/assign |
/unassign |
can you give an example? |
don't quite understand about this part |
For example, you create 11 databases. The id of databases is 0-10. RootCoord will save the key "root-coord/database/db-info/dbID" in snapshot. |
the easiest fix is to always drop root-coord/database/db-info/1/ ? |
The keys now do not contain delimiters at the end, may bring some compatibility issues. |
so we just want to delete 1 key? |
yes, from the code, it actually just want to delete 1 key, I have added the MultiSaveAndRemove in the snapshot interface. |
…milvus-io#33328) milvus-io#33288 --------- Signed-off-by: lixinguo <xinguo.li@zilliz.com> Co-authored-by: lixinguo <xinguo.li@zilliz.com>
Is there an existing issue for this?
Environment
Current Behavior
DropDatabase has already passed the dbID, remove with prefix in snapshot may remove another db which has the same prefix. In the case that it is not easy to have the same prefix (such as collectionID), load will also have better performance.Expected Behavior
No response
Steps To Reproduce
No response
Milvus Log
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: