Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[cherry-pick]Panic if ProcessActiveStandBy returns error #33371

Merged
merged 1 commit into from
May 27, 2024

Conversation

wayblink
Copy link
Collaborator

@wayblink wayblink commented May 24, 2024

pr:#33369
issue:#33368

Signed-off-by: wayblink <anyang.wang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 24, 2024
Copy link
Contributor

mergify bot commented May 24, 2024

@wayblink Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/bug Issues or changes related a bug label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 83.09%. Comparing base (078f252) to head (59691df).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #33371      +/-   ##
==========================================
- Coverage   83.11%   83.09%   -0.02%     
==========================================
  Files         850      850              
  Lines      106716   106716              
==========================================
- Hits        88692    88671      -21     
- Misses      14716    14743      +27     
+ Partials     3308     3302       -6     
Files Coverage Δ
internal/querycoordv2/server.go 82.66% <0.00%> (ø)
internal/rootcoord/root_coord.go 91.79% <0.00%> (ø)
internal/datacoord/server.go 71.86% <0.00%> (ø)

... and 16 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@xiaofan-luan xiaofan-luan merged commit d409298 into milvus-io:2.3 May 27, 2024
12 of 14 checks passed
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wayblink, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants