enhance: Periodically synchronize segments to datanode watcher #33420
Conversation
mergify
bot
added
dco-passed
|
@xiaocai2333 ut workflow job failed, comment |
|
@xiaocai2333 E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33420 +/- ##
==========================================
- Coverage 82.21% 82.19% -0.02%
==========================================
Files 1012 1013 +1
Lines 129202 129387 +185
==========================================
+ Hits 106223 106353 +130
- Misses 19001 19060 +59
+ Partials 3978 3974 -4
|
|
/run-cpu-e2e |
|
@xiaocai2333 E2e jenkins job failed, comment |
xiaocai2333
force-pushed
the
update_sync_segments
branch
from
7f27783
to
21c2b45
Compare
|
@xiaocai2333 ut workflow job failed, comment |
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
xiaocai2333
force-pushed
the
update_sync_segments
branch
from
0fa524c
to
5ebd62a
Compare
sre-ci-robot
added
size/XXL
| log := log.With(zap.Int64("collectionID", collectionID), zap.Int64("partitionID", partitionID), | ||
| zap.String("channelName", channelName), zap.Int64("nodeID", nodeID)) | ||
| segments := sss.meta.SelectSegments(WithCollection(collectionID), WithChannel(channelName), SegmentFilterFunc(func(info *SegmentInfo) bool { | ||
| return info.GetPartitionID() == partitionID |
There was a problem hiding this comment.
Add a new WithPartition filter
There was a problem hiding this comment.
no need to do this.
| } | ||
|
|
||
| for _, seg := range segments { | ||
| compactTo := int64(-1) |
There was a problem hiding this comment.
No need to related to compaction any more.
| zap.Error(err)) | ||
| continue | ||
| } | ||
| for _, channelName := range collInfo.VChannelNames { |
There was a problem hiding this comment.
Maybe we can execute concurrently at the channel level?
There was a problem hiding this comment.
I thinks it's no necessary. I already add the concurrently for load pk in datanode.
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
|
@xiaocai2333 ut workflow job failed, comment |
|
rerun ut |
| @@ -285,3 +248,56 @@ func (c *metaCacheImpl) rangeWithFilter(fn func(id int64, info *SegmentInfo), fi | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func (c *metaCacheImpl) DetectMissingSegments(segments map[int64]struct{}) []int64 { | |||
| c.mu.Lock() | |||
There was a problem hiding this comment.
yeah, oversight.
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
| select { | ||
| case <-sss.quit: | ||
| log.Info("sync segments scheduler quit") | ||
| ticker.Stop() |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, xiaocai2333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…s-io#33420) issue: milvus-io#32809 --------- Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
…s-io#33420) issue: milvus-io#32809 --------- Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
…s-io#33420) issue: milvus-io#32809 --------- Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
…s-io#33420) issue: milvus-io#32809 --------- Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
…watcher (#33420) (#34186) This PR primary picks up the SyncSegments functionality, including the following commits: - main functionality: #33420 - related fixes: - #33664 - #33829 - #34056 - #34156 issue: #32809 master pr: #33420, #33664, #33829, #34056, #34156 Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
…s-io#33420) issue: milvus-io#32809 --------- Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
issue: #32809