fix: Prevent remove new growing L1 segment when SyncSegments #34056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Related to milvus-io#34018 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
force-pushed
the
fix/sync_not_remove_growing_l1
branch
from
a84976f
to
38e3bac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34056 +/- ##
==========================================
- Coverage 81.00% 81.00% -0.01%
==========================================
Files 1067 1067
Lines 136726 136726
==========================================
- Hits 110759 110758 -1
+ Misses 21754 21749 -5
- Partials 4213 4219 +6
|
1 task
|
@xiaocai2333 please pick with #34156 |
xiaocai2333
pushed a commit
to xiaocai2333/milvus
that referenced
this pull request
Jun 26, 2024
…io#34056) Related to milvus-io#34018 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jun 27, 2024
…watcher (#33420) (#34186) This PR primary picks up the SyncSegments functionality, including the following commits: - main functionality: #33420 - related fixes: - #33664 - #33829 - #34056 - #34156 issue: #32809 master pr: #33420, #33664, #33829, #34056, #34156 Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
yellow-shine
pushed a commit
to yellow-shine/milvus
that referenced
this pull request
Jul 2, 2024
…io#34056) Related to milvus-io#34018 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #34018