Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync partitiion stats blocking balance task(#33741) #33742

Merged

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Jun 11, 2024

related: #33741

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/M Denotes a PR that changes 30-99 lines. labels Jun 11, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jun 11, 2024
Copy link
Contributor

mergify bot commented Jun 11, 2024

@MrPresent-Han

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@MrPresent-Han MrPresent-Han changed the title fix sync partitiion stats blocking balance task(#33741) fix: sync partitiion stats blocking balance task(#33741) Jun 11, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.55%. Comparing base (a1232fa) to head (b713fc6).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33742      +/-   ##
==========================================
- Coverage   80.88%   80.55%   -0.34%     
==========================================
  Files        1051     1058       +7     
  Lines      134863   135001     +138     
==========================================
- Hits       109088   108752     -336     
- Misses      21590    22057     +467     
- Partials     4185     4192       +7     
Files Coverage Δ
internal/datacoord/handler.go 74.61% <100.00%> (+0.09%) ⬆️
internal/querycoordv2/checkers/balance_checker.go 95.12% <100.00%> (ø)
internal/querycoordv2/checkers/controller.go 95.69% <100.00%> (ø)
internal/querycoordv2/checkers/leader_checker.go 96.15% <100.00%> (+1.49%) ⬆️
pkg/util/paramtable/component_param.go 98.45% <ø> (-0.01%) ⬇️
internal/querycoordv2/task/action.go 90.81% <0.00%> (-3.98%) ⬇️

... and 48 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 11, 2024
@czs007
Copy link
Contributor

czs007 commented Jun 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f7af323 into milvus-io:master Jun 11, 2024
15 checks passed
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Jun 26, 2024
@mergify mergify bot removed the ci-passed label Jun 26, 2024
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
wayblink pushed a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
wayblink pushed a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
…lvus-io#33742)

related: milvus-io#33741

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
…lvus-io#33742)

related: milvus-io#33741

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
@czs007 czs007 removed the PR | need cherry-pick need cherry pick to other branches label Jul 2, 2024
@mergify mergify bot added the ci-passed label Jul 2, 2024
czs007 pushed a commit that referenced this pull request Jul 3, 2024
This PR cherry-picks the following commits:

- fix: sync partitiion stats blocking balance task #33742
- fix: Fix meta prefix overlap bug #33830
- fix: Small fixs of major compaction #33929 
- fix: Fix memory buffer error & some renaming #33850
- fix: sync part stats task cannot be finished #34027 
- Add an option to enable/disable vector field clustering key #34097
- fix: fix error ignore in compactor #34169
- fix:load major compaction partial result #34052
- Use new stream segment reader in clustering compaction #34232

issue: #30633
pr: #33742 #33830 #33929 #33850 #34027 #34097 #34169 #34052 #34232

---------

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: Chun Han <116052805+MrPresent-Han@users.noreply.github.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants