Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Cherry-pick]Pick major compaction fixs and optimizations #34360

Merged
merged 9 commits into from
Jul 3, 2024

Conversation

wayblink
Copy link
Collaborator

@wayblink wayblink commented Jul 2, 2024

This PR cherry-picks the following commits:

issue: #30633
pr: #33742 #33830 #33929 #33850 #34027 #34097 #34169 #34052 #34232

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing test/integration integration test labels Jul 2, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jul 2, 2024
Copy link
Contributor

mergify bot commented Jul 2, 2024

@wayblink Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the kind/bug Issues or changes related a bug label Jul 2, 2024
Copy link
Contributor

mergify bot commented Jul 2, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@wayblink wayblink force-pushed the pick-major-2.4-new branch 2 times, most recently from e1f5624 to fe98285 Compare July 2, 2024 12:11
MrPresent-Han and others added 9 commits July 2, 2024 20:13
…lvus-io#33742)

related: milvus-io#33741

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
milvus-io#30633

Signed-off-by: wayblink <anyang.wang@zilliz.com>
milvus-io#30633

Signed-off-by: wayblink <anyang.wang@zilliz.com>
---------

Signed-off-by: wayblink <anyang.wang@zilliz.com>
…-io#34027)

related: milvus-io#30376
also: refine log output for query_coord task by rephrasing action string

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
milvus-io#34170

Signed-off-by: wayblink <anyang.wang@zilliz.com>
…34052)

related: milvus-io#34051

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jul 2, 2024
Copy link
Contributor

mergify bot commented Jul 2, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@wayblink
Copy link
Collaborator Author

wayblink commented Jul 2, 2024

/run-cpu-e2e

@czs007 czs007 added this to the 2.4.6 milestone Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 56 lines in your changes missing coverage. Please review.

Project coverage is 80.76%. Comparing base (7ee4ccb) to head (a72b9bb).
Report is 9 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34360      +/-   ##
==========================================
- Coverage   81.46%   80.76%   -0.70%     
==========================================
  Files        1028     1034       +6     
  Lines      132427   134672    +2245     
==========================================
+ Hits       107879   108766     +887     
- Misses      20474    21714    +1240     
- Partials     4074     4192     +118     
Files Coverage Δ
internal/datacoord/compaction_task_clustering.go 47.72% <100.00%> (ø)
internal/datanode/compaction/segment_writer.go 84.55% <100.00%> (+0.79%) ⬆️
internal/proxy/impl.go 86.19% <100.00%> (+<0.01%) ⬆️
internal/proxy/task.go 87.70% <100.00%> (-0.03%) ⬇️
internal/querycoordv2/checkers/balance_checker.go 95.12% <100.00%> (ø)
internal/querycoordv2/task/task.go 97.70% <100.00%> (+0.01%) ⬆️
internal/querynodev2/delegator/delegator.go 86.87% <100.00%> (+0.21%) ⬆️
internal/storage/partition_stats.go 81.39% <100.00%> (+2.08%) ⬆️
internal/storage/serde.go 88.05% <100.00%> (+0.04%) ⬆️
pkg/common/map.go 100.00% <100.00%> (ø)
... and 9 more

... and 35 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jul 2, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 3, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 merged commit c62bf8a into milvus-io:2.4 Jul 3, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test dco-passed DCO check passed. kind/bug Issues or changes related a bug sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants